Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved "generate debug log" flow #212

Merged
merged 12 commits into from
Sep 3, 2024
Merged

Improved "generate debug log" flow #212

merged 12 commits into from
Sep 3, 2024

Conversation

budak7273
Copy link
Member

  • Now the user must generate a debug log before they can click on the discord invite (hopefully cut down on people screenshotting the error without attaching the file)
  • Error handling for when the debug log fails to generate for some reason
  • Deduplicated error code between the modal and mods-list-replacer variants

image
image
image

mircearoata
mircearoata requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mircearoata mircearoata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button placement looks a bit strange in the non full-page version, I think moving them to the bottom right or left of the dialog, like the debug info button was before, would be better

@budak7273
Copy link
Member Author

image

mircearoata
mircearoata requested changes Sep 3, 2024
View reviewed changes
@mircearoata mircearoata merged commit ed01b5f into master Sep 3, 2024
16 checks passed
@budak7273 budak7273 deleted the generate-debug-flow branch September 4, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircearoata mircearoata mircearoata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Mod Manager (SMM) and CLI
Status: ✅ Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@budak7273 @mircearoata